Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supported_options #4

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Conversation

netux
Copy link
Contributor

@netux netux commented Feb 18, 2024

I found it frustrating to install the latest FFmpeg (6.1.1), in part due to this behavior of filtering out options if they are not available.

The FFmpeg build already throws an error if an argument is not in supported, the all option that also used this supported_options list was removed recently, and the list itself hasn't been updated in 2 years. So I don't see why it should be kept in.

netux and others added 2 commits February 18, 2024 01:17
Remove functionality that filters out addons not present on a hard-coded list
@acj
Copy link
Owner

acj commented Feb 18, 2024

Sorry for the frustration. I agree that supported_options doesn't provide much value without the all alias. Another benefit to removing it is that we won't need to maintain a list of options in the readme.

Thanks!

@acj acj merged commit 6286583 into acj:main Feb 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants