Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tools] Implement lorisInstance in tools directory #9397

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[tools] Implement lorisInstance in tools directory #9397

wants to merge 5 commits into from

Conversation

victori444
Copy link
Contributor

@victori444 victori444 commented Oct 8, 2024 •
edited
Loading

Brief summary of changes

  • Implements lorisInstance in detect_conflicts.php

  • Resolves other errors found in detect_conflicts.php & fix_candidate_age.php (accessing $commentIDs as an array & querying Test_name)

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Run each of the scripts below and verify that no errors are thrown

Link(s) to related issue(s)

@victori444 victori444 added Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix and removed Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix labels Oct 8, 2024
@CamilleBeau CamilleBeau mentioned this pull request Oct 31, 2024
Open
@CamilleBeau
Copy link
Contributor

@victori444 Assigning to you to resolve conflicts and then I'll test / review!

@driusan
Copy link
Collaborator

driusan commented Nov 11, 2024

does this resolve the issue listed or only partially resolve it? (There are many places listed in the issue and merging it with "Resolved" will close the issue automatically)

@CamilleBeau
Copy link
Contributor

According to the comments of the issue, these were the only 2 remaining out of the initial list

@victori444 victori444 force-pushed the 2024_10_08_LorisInstance_In_Tools branch from 4b6a810 to 11e3717 Compare November 11, 2024 20:15
@victori444 victori444 removed their assignment Nov 12, 2024
CamilleBeau
CamilleBeau requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a lot of these when running detect_conflicts -r all -y:
image

tools/data_integrity/fix_candidate_age.php Show resolved Hide resolved
@CamilleBeau CamilleBeau added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Nov 18, 2024
@victori444 victori444 removed their assignment Nov 19, 2024
@victori444 victori444 removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamilleBeau CamilleBeau Awaiting requested review from CamilleBeau

Requested changes must be addressed to merge this pull request.

Assignees

@CamilleBeau CamilleBeau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tools] Implement LorisInstance in tools directory
3 participants
@victori444 @CamilleBeau @driusan