Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

81/fix padronizar imagens #90

Merged
merged 3 commits into from
Oct 22, 2024
Merged

81/fix padronizar imagens #90

merged 3 commits into from
Oct 22, 2024

Conversation

pollianasilva
Copy link
Contributor

@pollianasilva pollianasilva commented Oct 22, 2024 •
edited by Lip29bm
Loading

#<81> - fix: padronizar as imagens nos cards

🆙 CHANGELOG

  • Ver o tamanho correto das imagens no cards;
  • Colocar imagens de boa qualidade e de acordo com o tópico;
  • Utilizar o atributo alt , colocando a descrição das imagens;

⚠️ Me certifico que:

  • Não deixei nenhum novo warning, erro ou console.log nas minhas modificações
  • Solicitei code review para 2 pessoas
  • Solicitei QA para 2 pessoas
  • Obtive aprovação de QA e posso fazer merge

⚠️ Como testar:

  • Fazer deploy em ambiente de teste
  • Abrir URL da aplicação de teste - src/components/BaseCard/index.tsx
  • Verificar se as imagens estão de qualidade e tamanho correto
  • Verificar o alt
  • Aplicação não deve conter nenhum erro, warning ou console.log
  • Alteração proposta no card foi implementada

@daniellemadrid daniellemadrid merged commit fdae159 into main Oct 22, 2024
0 of 8 checks passed
@daniellemadrid daniellemadrid deleted the 81/fix-padronizar-imagens branch October 22, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellemadrid daniellemadrid daniellemadrid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pollianasilva @daniellemadrid