Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

186/import tipo do desafio #190

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ErickCardoso007
Copy link
Contributor

@ErickCardoso007 ErickCardoso007 commented Jul 5, 2022

#186 - import: tipo do desafio

🆙 CHANGELOG

Esses passos são apenas exemplos

  • exibir tipo de desafio (Frontend/Backend)
  • Caso não tenha sido definido, exibe (não definido)

⚠️ Me certifico que:

  • Não deixei nenhum novo warning, erro ou console.log nas minhas modificações
  • Fiz deploy para ambiente de teste certificando que o build não quebrou
  • Solicitei code review para 2 pessoas
  • Solicitei QA para 2 pessoas
  • Obtive aprovação de QA e posso fazer merge

⚠️ Como testar:

Esses passos são apenas exemplos

@@ -9,6 +9,7 @@ const responseHandle = httpResponseHandler()

const mapCandidates = (id) => {
const normaliseDate = (date) => {
return date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esse return n pode ser commitado

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foi deletado.

@@ -12,6 +12,7 @@ const httpResponse = httpResponseHandler()

const mapChallenges = (id) => {
const normaliseDate = (date) => {
return date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esse aqui tb n

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alteração feita

@leonardogomesp
Copy link
Contributor

aprovei, não esqueçam de fazer outro deploy antes de enviar para QA

@MarquesEmiLly MarquesEmiLly temporarily deployed to emilly-acelera-mais-api July 6, 2022 12:32 Inactive
@MarquesEmiLly MarquesEmiLly temporarily deployed to emilly-acelera-mais-api July 6, 2022 13:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants