-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Structure Change + Code Cleanup #167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 90.34% 92.62% +2.27%
==========================================
Files 26 47 +21
Lines 818 1206 +388
Branches 113 171 +58
==========================================
+ Hits 739 1117 +378
- Misses 69 78 +9
- Partials 10 11 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but please prettier the files first :) (yarn format
)
Yes sure, I am waiting for the tslint PRs to be merged first ;) |
Monorepo : added rest-client & rest-express to the monorepo
package.json
Outdated
@@ -35,7 +35,7 @@ | |||
}, | |||
"license": "MIT", | |||
"devDependencies": { | |||
"@accounts/tslint-config-accounts": "0.0.6", | |||
"@accounts/tslint-config-accounts": "^0.0.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you keep strict deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sure !
…ved tslint.json + removed .circleci folder
@accounts/mongo : Monorepo integration
…into code-cleanup
Create new PR to reflect master changes |
The goal here is to incrementally update the file structure in order to make the Accounts Suite structure more consistent.
Any help is welcome, as well as reviews and opinions