Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Structure Change + Code Cleanup #167

Closed
wants to merge 131 commits into from
Closed

File Structure Change + Code Cleanup #167

wants to merge 131 commits into from

Conversation

Aetherall
Copy link
Member

The goal here is to incrementally update the file structure in order to make the Accounts Suite structure more consistent.

Any help is welcome, as well as reviews and opinions

@codecov-io
Copy link

codecov-io commented Mar 10, 2018

Codecov Report

Merging #167 into master will increase coverage by 2.27%.
The diff coverage is 99.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   90.34%   92.62%   +2.27%     
==========================================
  Files          26       47      +21     
  Lines         818     1206     +388     
  Branches      113      171      +58     
==========================================
+ Hits          739     1117     +378     
- Misses         69       78       +9     
- Partials       10       11       +1
Impacted Files Coverage Δ
packages/password/src/utils/encryption.ts 100% <ø> (ø)
packages/server/src/utils/encryption.ts 93.33% <ø> (ø)
packages/server/src/utils/email.ts 81.81% <ø> (ø)
packages/server/src/utils/get-first-user-email.ts 27.27% <ø> (ø)
packages/oauth-twitter/src/index.ts 100% <ø> (ø) ⬆️
packages/server/src/utils/tokens.ts 100% <ø> (ø)
packages/oauth/src/accounts-oauth.ts 100% <ø> (ø) ⬆️
...ckages/oauth-twitter/src/accounts-oauth-twitter.ts 30.76% <0%> (ø) ⬆️
packages/rest-express/src/utils/get-user-agent.ts 100% <100%> (ø)
packages/server/src/index.ts 100% <100%> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e55ef...16d09ff. Read the comment docs.

Copy link
Member

@pradel pradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but please prettier the files first :) (yarn format)

@Aetherall
Copy link
Member Author

Yes sure, I am waiting for the tslint PRs to be merged first ;)
accounts-js/tslint-config-accounts#3
accounts-js/tslint-config-accounts#4

package.json Outdated
@@ -35,7 +35,7 @@
},
"license": "MIT",
"devDependencies": {
"@accounts/tslint-config-accounts": "0.0.6",
"@accounts/tslint-config-accounts": "^0.0.9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you keep strict deps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sure !

@Aetherall Aetherall changed the title WIP : File Structure Change + Code Cleanup File Structure Change + Code Cleanup Mar 13, 2018
Aetherall and others added 2 commits March 13, 2018 12:38
@Aetherall Aetherall mentioned this pull request Mar 13, 2018
12 tasks
@Aetherall
Copy link
Member Author

Create new PR to reflect master changes

@Aetherall Aetherall closed this Mar 14, 2018
@pradel pradel deleted the code-cleanup branch March 20, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants