Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add const qualifier to static strings (#662) #688

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

neomantra
Copy link

This squelches a compiler warning, but also prevents run-time
modification of kDefaultLoggerId, kPerformanceLoggerId,
and kSysLogLoggerId.

This is a
Breaking change
New feature
Bugfix
I have
[ Yes ] Merged in the latest upstream changes

[ No ] Updated CHANGELOG.md
This seemed minor bugfix, but will make entry if desired.

[ No ] Updated README.md

[ Yes ] Run the tests
I did run the tests in a test Docker image based on Xenial. I had to add pthread to the target_link_libraries to get them to build (not part of this PR).
I had the same failures between this changeset and master.

This squelches a compiler warning, but also prevents run-time
modification of `kDefaultLoggerId`, `kPerformanceLoggerId`,
and `kSysLogLoggerId`
@neomantra neomantra changed the base branch from master to develop November 27, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant