Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistents between readme and manifet files in Workloads and Storage #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions storage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,11 @@ spec:
storage: 2Gi
accessModes:
- ReadWriteMany
persistentVolumeReclaimPolicy: Delete
storageClassName: mypvsc
persistentVolumeReclaimPolicy: Delete
hostPath:
type: DirectoryOrCreate
path: "/data/mypvsc"
path: "/tmp/mypvsc"
```

**Command**
Expand Down Expand Up @@ -263,9 +263,10 @@ spec:
storage: 2Gi
accessModes:
- ReadWriteMany
persistentVolumeReclaimPolicy: Retain
hostPath:
type: DirectoryOrCreate
path: "/data/mypvselector"
path: "/tmp/mypvselector"
```

**Command**
Expand Down
2 changes: 1 addition & 1 deletion storage/manifests/pvc-selector-example.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
kind: PersistentVolumeClaim
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: pvc-selector-example
spec:
Expand Down
1 change: 0 additions & 1 deletion storage/manifests/volume-example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,3 @@ spec:
volumes:
- name: html
emptyDir: {}

4 changes: 2 additions & 2 deletions workloads/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ configure the labels and selectors to target `app=nginx` and `env=prod`. The yam
apiVersion: apps/v1
kind: ReplicaSet
metadata:
name: example-rs
name: rs-example
spec:
replicas: 3
selector:
Expand Down Expand Up @@ -183,7 +183,7 @@ and Pod.
`manifests/deploy-example.yaml`. Additionally pass the `--record` flag to `kubectl` when you create the Deployment.
The `--record` flag saves the command as an annotation, and it can be thought of similar to a git commit message.

**manifests/deployment-example.yaml**
**manifests/deploy-example.yaml**
```yaml
apiVersion: apps/v1
kind: Deployment
Expand Down
2 changes: 0 additions & 2 deletions workloads/manifests/deploy-example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,3 @@ spec:
image: nginx:stable-alpine
ports:
- containerPort: 80