Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the first tab active after search in permissions #21210

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

enisn
Copy link
Member

@enisn enisn commented Oct 30, 2024

Description

Resolves https://github.com/volosoft/volo/issues/18704
Resolves https://github.com/volosoft/volo/issues/18703

permissions-search

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

@enisn enisn added this to the 9.0-final milestone Oct 30, 2024
@enisn enisn requested a review from oykuermann October 30, 2024 08:40
@enisn enisn changed the base branch from dev to rel-9.0 October 30, 2024 08:41
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I write open, it cannot find OpenId:
image

@oykuermann
Copy link
Contributor

  • After filtering & pressing 'Grant all permissions', I expect to see only filtering items to be selected.
screencast-localhost_44318-2024_10_23-17_20_54.webm

I asked this, and this is how it should work

@enisn
Copy link
Member Author

enisn commented Oct 31, 2024

When I write open, it cannot find OpenId: image

I cannot reproduce this issue. It's probably related to your browser language. In Turkish I and i are differently compared

@enisn
Copy link
Member Author

enisn commented Oct 31, 2024

  • After filtering & pressing 'Grant all permissions', I expect to see only filtering items to be selected.

screencast-localhost_44318-2024_10_23-17_20_54.webm
I asked this, and this is how it should work

It's a new feature and requires bigger changes, you can create a new issue as feature for this

@oykuermann
Copy link
Contributor

I tried openI openi openı and openİ, none of them is worked :(

Roles._.MyProjectName.mp4

When I write open, it cannot find OpenId: image

I cannot reproduce this issue. It's probably related to your browser language. In Turkish I and i are differently compared

@enisn enisn requested a review from oykuermann November 7, 2024 10:04
@oykuermann oykuermann merged commit 60fd0c2 into rel-9.0 Nov 7, 2024
2 checks passed
@oykuermann oykuermann deleted the 9.0-permission-search-mvc branch November 7, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants