AngularUI: Remove confirmation for 401 status code #17544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rqx110
reviewed
Sep 4, 2023
npm/ng-packs/packages/theme-shared/src/lib/services/status-code-error-handler.service.ts
Outdated
Show resolved
Hide resolved
This reverts commit 3dac4e6.
mahmut-gundogdu
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I separate PR because 7.4+ version error handler updated
Resolves for 7.4 version #17529
TODO: Remove confirmation modal for 401 status code,
this PR also resolves for commercial sideChecklist
How to test it?
Send request before authenticate, it'll return 401 instead 403 and error handler will display a confirmation and it'll redirect to login. Try for password flow it works same for code flow