🐛 FFdecoder: Refactored Process Termination and various important updates. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🏗️ Increased `python_requires` to `3.8` and above. - 🔥 Removed depreciated Python-3.7 from metadata.
…Seeking methods. (Fixes #44) - 📝 Introduced `Input Seeking` and `Output Seeking` sections with pros, cons, and usage examples. - 🚸 Added warning about using output seeking with filters for accuracy. - 🎨 Improved overall document structure and readability.
- 🚀 Changed process termination from `kill` to `terminate` if the process is still running. - Ensures that the process is terminated gracefully using `terminate()` instead of `kill()`. - The terminate() method sends the SIGTERM signal to a process, which typically allows for a graceful shutdown. On Unix, this uses the SIGTERM signal, while on Windows, it uses TerminateProcess(). - 🎨 Simplified conditional check using short-circuiting.
abhiTronix
added
Enhancement ⚡
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 95.84% 95.83% -0.01%
==========================================
Files 6 6
Lines 794 793 -1
==========================================
- Hits 761 760 -1
Misses 33 33 ☔ View full report in Codecov by Sentry. |
abhiTronix
added
Solved 🥅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This pull request includes several significant updates and improvements:
Title: End Support for Python 3.7, Improve Documentation, and Refactor Process Termination
End of Support for Python 3.7 (Fixes [Idea]: End of Support for Python 3.7.x Legacy #48):
Documentation Enhancements (Fixes [Bug]: frame extraction by timestamp operation can be very slow #44):
Input SeekingandOutput Seeking, highlighting their pros, cons, and providing usage examples.FFdecoder Process Termination Refactor (Fixes [Question]: while input stream have stop , deffcode will not stop but just hold on #41):
terminate()instead ofkill()for a more graceful shutdown.terminate()method sends the appropriate signal (SIGTERM on Unix, TerminateProcess() on Windows).Requirements / Checklist
Related Issue
#48
#44
#41
Context
These changes collectively aim to modernize the codebase by discontinuing support for outdated Python versions, enhance the documentation for better user understanding, and ensure more reliable and graceful process termination methods.
Types of changes