Skip to content

Commit

Permalink
Fixed team memberships controller allowed? bug
Browse files Browse the repository at this point in the history
  • Loading branch information
abartov committed Nov 25, 2024
1 parent 15bdcf1 commit 0d5666b
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 3 deletions.
41 changes: 39 additions & 2 deletions TODO
Original file line number Diff line number Diff line change
@@ -1,4 +1,41 @@
- search by source field (publisher information)
# teams to-do

+ team#show
+ show team info,
+ stats
+ join/leave button for volunteers
+ in user's profile page:
+ user can join team
+ user can leave team
- admin's team info and editing screen
- team detailed stats
+ add / remove tasks
+ add / remove users
+ edit team settings
+ add / remove team leads
+ mass-message team members
+ task allocation screen
+ filter by team
+ task editing screen
+ associate with team
+ remove association with team

+ include team in search form and results
- tasks search results
- add all to team
- remove all from team

## post 1.0
- task allocation screen
- default to allocating within user's teams
- allocate random task within team pool
- optionally specify team when requesting new task and member of multiple teams
- optionally self-allocate random task within team pool
- team discussion board?
- notifications to team leaders when volunteers join/leave? by preference?
- team status; archiving teams

== general todo ==
- fix sorting in task list views
- send volunteers e-mails when works they were involved with have been uploaded.
+ send volunteers e-mails when works they were involved with have been uploaded.
- As weekly cronjob, perhaps, updating about all uploads since last run. No more than one e-mail per user per week!
2 changes: 1 addition & 1 deletion app/controllers/team_memberships_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@ def set_tm
end

def allowed?
current_user.admin_or_editor? || current_user == User.find(pp[:user_id])
current_user.admin_or_editor? || current_user == User.find(team_membership_params[:user_id])
end
end

0 comments on commit 0d5666b

Please sign in to comment.