-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STETH to Aave V2 #267
Open
Psirex
wants to merge
63
commits into
aave:fat-deployment
Choose a base branch
from
lidofinance:feature/steth-on-prev-version
base: fat-deployment
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add STETH to Aave V2 #267
Psirex
wants to merge
63
commits into
aave:fat-deployment
from
lidofinance:feature/steth-on-prev-version
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[QSP-2] Formulas in _mintScaled and _burnScaled cannot be verified
Add tests coverage for stETH
AStETH rounding fix with rebasingIndex
Fix AStETH rounding issue
stEthAddress, | ||
treasuryAddress, | ||
'Aave interest bearing stETH', | ||
`astETH`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The final tokens have different name and symbols. Could you please update their scripts to reflect the final tokens' configurations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lido's stETH represents the user’s staked ETH balance of the beacon chain along with staking rewards accrued or penalties inflicted on validators in the beacon chain.
Due to the rebasing nature of stETH, the proposed listing implementation involves few changes to AAVE’s generic aToken.
The proposed aToken uses underlying stETH shares to store balances and implement the rebase ability. Thus, it has 2 private balances and 1 public balance.
Externally, the aSTETH behaves similar to every other aToken. It always maintains a 1:1 peg with the underlying stETH.
The current implementation doesn’t support borrowing, neither with variable nor with stable interest rates. The stableDebtSTETH and variableDebtSTETH contracts extend default stableDebtToken and variableDebtToken contracts accordingly to make it impossible to use borrowing with aSTETH because default debt tokens are not compatible with the AStETH contract.
Implementation has been audited by MixBytes: https://github.com/lidofinance/audits/blob/main/MixBytes%20AAVE%20stETH%20integration%20Security%20Audit%20Report%2002-22.pdf
To deploy
AStETH
,VariableDebtStETH
,StableDebtStETH
, andDefaultReserveInterestRateStrategy
used standalone deployment script https://github.com/lidofinance/aave-asteth-deployment .