Throw an exception on duplicate keys #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaubry
force-pushed
the
master
branch
8 times, most recently
from
a0f8359
to
78b1ab3
Compare
|
I would prefer if this was done as an option and defaulted to the current behavior. In the deserializer builder, we would add another method, something like |
|
I went without the option because duplicate keys are not valid YAML but I will update today to make it optional. |
|
Changing the behavior of the library may cause unexpected issues for the consumers which is why I would like to see it as optional to opt in. Maybe in a future major version release we’ll make it the default.
…________________________________
From: Chris Nussbaum ***@***.***>
Sent: Thursday, December 8, 2022 7:31:11 AM
To: aaubry/YamlDotNet ***@***.***>
Cc: Edward Cooke ***@***.***>; Comment ***@***.***>
Subject: Re: [aaubry/YamlDotNet] Throw an exception on duplicate keys (PR #750)
I went without the option because duplicate keys are not valid YAML but I will update today to make it optional.
—
Reply to this email directly, view it on GitHub<#750 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATMSFE72N4JAAIFKWRY276TWMHWK7ANCNFSM6AAAAAASSHT5EQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Sorry about the delay in getting this PR updated, been sucked into multiple things at work. I have updated to make the duplicate key checking optional. Let me know if you don't like the naming. |
|
Merged! Yay. |
|
This feature has been released in version 12.2.1. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializing YAML with non-unique keys throws a YamlException. Resolves #536