Annotate or remove unused elements.

aaru-dps · Oct 5, 2023 · bb23889 · bb23889
1 parent acbc11a
commit bb23889
Show file tree

Hide file tree

Showing 49 changed files with 104 additions and 279 deletions.
diff --git a/Bluray/DI.cs b/Bluray/DI.cs
@@ -56,6 +56,7 @@ namespace Aaru.Decoders.Bluray;
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
 [SuppressMessage("ReSharper", "NotAccessedField.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public static class DI
 {
 #region BluSize enum

diff --git a/CD/CDTextOnLeadIn.cs b/CD/CDTextOnLeadIn.cs
@@ -55,6 +55,8 @@ namespace Aaru.Decoders.CD;
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
 [SuppressMessage("ReSharper", "NotAccessedField.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class CDTextOnLeadIn
 {
 #region PackTypeIndicator enum

diff --git a/CD/Sector.cs b/CD/Sector.cs
@@ -42,6 +42,7 @@ namespace Aaru.Decoders.CD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public static class Sector
 {
     public static readonly byte[] ScrambleTable =

diff --git a/DVD/AACS.cs b/DVD/AACS.cs
@@ -51,6 +51,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class AACS
 {
 #region Nested type: HDLeadInCopyright

diff --git a/DVD/ADIP.cs b/DVD/ADIP.cs
@@ -51,6 +51,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class ADIP
 {
 #region Nested type: ADIPInformation

diff --git a/DVD/BCA.cs b/DVD/BCA.cs
@@ -51,6 +51,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class BCA
 {
 #region Nested type: BurstCuttingArea

diff --git a/DVD/CPRM.cs b/DVD/CPRM.cs
@@ -51,6 +51,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class CPRM
 {
 #region Nested type: DiscMediaIdentifier

diff --git a/DVD/CSS&CPRM.cs b/DVD/CSS&CPRM.cs
@@ -54,6 +54,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
 [SuppressMessage("ReSharper", "NotAccessedField.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class CSS_CPRM
 {
     public static LeadInCopyright? DecodeLeadInCopyright(byte[] response)

diff --git a/DVD/DMI.cs b/DVD/DMI.cs
@@ -51,6 +51,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class DMI
 {
 #region Nested type: DiscManufacturingInformation

diff --git a/DVD/Enums.cs b/DVD/Enums.cs
@@ -30,13 +30,15 @@
 // Copyright © 2011-2023 Natalia Portillo
 // ****************************************************************************/
 
-using System.Diagnostics.CodeAnalysis;
+
+// ReSharper disable UnusedMember.Global
+// ReSharper disable InconsistentNaming
+// ReSharper disable UnusedType.Global
 
 namespace Aaru.Decoders.DVD;
 
 #region Public enumerations
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum DiskCategory : byte
 {
     /// <summary>DVD-ROM. Version 1 is ECMA-267 and ECMA-268.</summary>
@@ -69,7 +71,6 @@ public enum DiskCategory : byte
     Nintendo = 15
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum MaximumRateField : byte
 {
     /// <summary>2.52 Mbps</summary>
@@ -85,7 +86,6 @@ public enum MaximumRateField : byte
     Unspecified = 0x0F
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum LayerTypeFieldMask : byte
 {
     Embossed   = 0x01,
@@ -94,7 +94,6 @@ public enum LayerTypeFieldMask : byte
     Reserved   = 0x08
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum LinearDensityField : byte
 {
     /// <summary>0.267 μm/bit</summary>
@@ -113,7 +112,6 @@ public enum LinearDensityField : byte
     ThreeFive = 0x08
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum TrackDensityField : byte
 {
     /// <summary>0.74 μm/track</summary>
@@ -128,7 +126,6 @@ public enum TrackDensityField : byte
     Three = 0x04
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum CopyrightType : byte
 {
     /// <summary>There is no copy protection</summary>
@@ -141,7 +138,6 @@ public enum CopyrightType : byte
     AACS = 0x10
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum WPDiscTypes : byte
 {
     /// <summary>Should not write without a cartridge</summary>
@@ -152,7 +148,6 @@ public enum WPDiscTypes : byte
     Reserved2 = 0x03
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum DVDSize
 {
     /// <summary>120 mm</summary>
@@ -161,7 +156,6 @@ public enum DVDSize
     Eighty = 1
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum DVDRAMDiscType
 {
     /// <summary>Shall not be recorded without a case</summary>
@@ -170,7 +164,6 @@ public enum DVDRAMDiscType
     Uncased = 1
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum DVDLayerStructure
 {
     Unspecified   = 0,
@@ -179,7 +172,6 @@ public enum DVDLayerStructure
     Reserved      = 3
 }
 
-[SuppressMessage("ReSharper", "InconsistentNaming")]
 public enum DVDRecordingSpeed
 {
     None   = 0,

diff --git a/DVD/Layers.cs b/DVD/Layers.cs
@@ -51,6 +51,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public static class Layers
 {
 #region Nested type: JumpIntervalSize

diff --git a/DVD/PFI.cs b/DVD/PFI.cs
@@ -71,6 +71,7 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
 [SuppressMessage("ReSharper", "NotAccessedField.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public static class PFI
 {
     public static PhysicalFormatInformation? Decode(byte[] response, MediaType mediaType)

diff --git a/DVD/RMD.cs b/DVD/RMD.cs
@@ -51,6 +51,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class RMD
 {
 #region Nested type: HDMediumStatus

diff --git a/DVD/Sector.cs b/DVD/Sector.cs
@@ -33,11 +33,13 @@
 #nullable enable
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using Aaru.Helpers;
 
 namespace Aaru.Decoders.DVD;
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public sealed class Sector
 {
     static readonly ushort[] _ecma267InitialValues =

diff --git a/DVD/UDI.cs b/DVD/UDI.cs
@@ -51,6 +51,8 @@ namespace Aaru.Decoders.DVD;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class UDI
 {
 #region Nested type: UniqueDiscIdentifier

diff --git a/Floppy/Amiga.cs b/Floppy/Amiga.cs
@@ -39,6 +39,8 @@ namespace Aaru.Decoders.Floppy;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class Amiga
 {
 #region Nested type: Sector

diff --git a/Floppy/Apple2.cs b/Floppy/Apple2.cs
@@ -45,6 +45,8 @@ namespace Aaru.Decoders.Floppy;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "ClassCanBeSealed.Global")]
 public static class Apple2
 {
     const string MODULE_NAME = "Apple ][ GCR Decoder";
@@ -559,6 +561,7 @@ public static byte[] MarshalTrack(RawTrack track)
 
     public static List<RawTrack> MarshalDisk(byte[] data, int offset = 0) => MarshalDisk(data, out _, offset);
 
+    [SuppressMessage("ReSharper", "OutParameterValueIsAlwaysDiscarded.Global")]
     public static List<RawTrack> MarshalDisk(byte[] data, out int endOffset, int offset = 0)
     {
         endOffset = offset;

diff --git a/Floppy/AppleSony.cs b/Floppy/AppleSony.cs
@@ -47,6 +47,9 @@ namespace Aaru.Decoders.Floppy;
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
 [SuppressMessage("ReSharper", "NotAccessedField.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+[SuppressMessage("ReSharper", "OutParameterValueIsAlwaysDiscarded.Global")]
 public static class AppleSony
 {
     public static byte[] DecodeSector(RawSector sector)
@@ -444,7 +447,7 @@ public static bool IsAppleSonyGCR(byte[] data)
 #region Nested type: RawAddressField
 
     /// <summary>GCR-encoded Apple Sony GCR floppy sector address field</summary>
-    public class RawAddressField
+    public sealed class RawAddressField
     {
         /// <summary>Checksum</summary>
         public byte checksum;
@@ -469,7 +472,7 @@ public class RawAddressField
 #region Nested type: RawDataField
 
     /// <summary>GCR-encoded Apple ][ GCR floppy sector data field</summary>
-    public class RawDataField
+    public sealed class RawDataField
     {
         /// <summary>Checksum</summary>
         [MarshalAs(UnmanagedType.ByValArray, SizeConst = 4)]
@@ -492,7 +495,7 @@ public class RawDataField
 #region Nested type: RawSector
 
     /// <summary>GCR-encoded Apple Sony GCR floppy sector</summary>
-    public class RawSector
+    public sealed class RawSector
     {
         /// <summary>Address field</summary>
         public RawAddressField addressField;
@@ -509,7 +512,7 @@ public class RawSector
 #region Nested type: RawTrack
 
     /// <summary>GCR-encoded Apple Sony GCR floppy track</summary>
-    public class RawTrack
+    public sealed class RawTrack
     {
         /// <summary>Track preamble, set to self-sync 0xFF, 36 bytes</summary>
         public byte[] gap;

diff --git a/Floppy/Commodore.cs b/Floppy/Commodore.cs
@@ -39,6 +39,8 @@ namespace Aaru.Decoders.Floppy;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class Commodore
 {
 #region Nested type: SectorData

diff --git a/Floppy/Enums.cs b/Floppy/Enums.cs
@@ -57,6 +57,7 @@ public enum IBMSectorSizeCode : byte
 }
 
 [SuppressMessage("ReSharper", "InconsistentNaming")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum IBMIdType : byte
 {
     IndexMark       = 0xFC,
@@ -66,6 +67,7 @@ public enum IBMIdType : byte
 }
 
 [SuppressMessage("ReSharper", "InconsistentNaming")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum AppleEncodedFormat : byte
 {
     /// <summary>Disk is an Apple II 3.5" disk</summary>

diff --git a/Floppy/ISO.cs b/Floppy/ISO.cs
@@ -49,6 +49,8 @@ namespace Aaru.Decoders.Floppy;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class ISO
 {
 #region Nested type: AddressMark

diff --git a/Floppy/Perpendicular.cs b/Floppy/Perpendicular.cs
@@ -49,6 +49,8 @@ namespace Aaru.Decoders.Floppy;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class Perpendicular
 {
 #region Nested type: AddressMark

diff --git a/Floppy/System34.cs b/Floppy/System34.cs
@@ -49,6 +49,9 @@ namespace Aaru.Decoders.Floppy;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class System34
 {
 #region Nested type: AddressMark

diff --git a/Floppy/System3740.cs b/Floppy/System3740.cs
@@ -49,6 +49,8 @@ namespace Aaru.Decoders.Floppy;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 public static class System3740
 {
 #region Nested type: AddressMark

diff --git a/MMC/CID.cs b/MMC/CID.cs
@@ -56,6 +56,7 @@ public class CID
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public static partial class Decoders
 {
     public static CID DecodeCID(uint[] response)

diff --git a/MMC/CSD.cs b/MMC/CSD.cs
@@ -80,6 +80,7 @@ public class CSD
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public static partial class Decoders
 {
     public static CSD DecodeCSD(uint[] response)

diff --git a/MMC/ExtendedCSD.cs b/MMC/ExtendedCSD.cs
@@ -43,6 +43,8 @@ namespace Aaru.Decoders.MMC;
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
 [SuppressMessage("ReSharper", "UnassignedField.Global")]
 [StructLayout(LayoutKind.Sequential, Pack = 1)]
+[SuppressMessage("ReSharper", "NotAccessedField.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public class ExtendedCSD
 {
     public byte                            AccessSize;

diff --git a/MMC/OCR.cs b/MMC/OCR.cs
@@ -67,6 +67,7 @@ public class OCR
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public static partial class Decoders
 {
     public static OCR DecodeOCR(uint response)