Skip to content

Commit

Permalink
remove unused variables (#27)
Browse files Browse the repository at this point in the history
* remove unused variables

* update changelog
  • Loading branch information
glitchcrab authored Mar 10, 2023
1 parent a6ba478 commit 0e2002e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 22 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Removed

- Removed unused vars relating to cloud-init.

## [1.4.1] - 2023-03-05

### Changed
Expand Down
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ This module is an opinionated take on creating a VM in Proxmox; not all possible
|------|-------------|------|---------|:--------:|
| boot | Boot order for the instance. | `string` | `"cdn"` | no |
| cicustom | Path(s) to cloud-init config files (ignored when pxe_boot is true). | `string` | `null` | no |
| citemplate_storage | Name of the storage containing the cloud-init snippets (ignored when pxe_boot is true). | `string` | `null` | no |
| clone | Name of the template to clone (ignored when pxe_boot is true). | `string` | `null` | no |
| cloudinit_cdrom_storage | Name of the storage to create the cloud-init image in (e.g. local-lvm). | `string` | `null` | no |
| cores | Number of cores to allocate. | `number` | n/a | yes |
Expand All @@ -28,8 +27,6 @@ This module is an opinionated take on creating a VM in Proxmox; not all possible
| pxe_boot | Set PXE boot mode | `bool` | `null` | no |
| qemu_agent | Enable QEMU guest agent (must be installed in the template). Set to `1` to enable or `0` to disable. | `number` | `0` | no |
| resource_pool | Name of the resource pool the assign the instance to. | `string` | n/a | yes |
| snippet_dir | Name of the snippet subdirectory. | `string` | `"snippets"` | no |
| snippet_file_base | Path to the directory containing the snippet_dir. | `string` | `"/var/lib/vz"` | no |
| sockets | Number of sockets to allocate. | `number` | n/a | yes |
| target_node | Name of the node to assign the instance to. | `string` | n/a | yes |
| vmid | ID of the VM (must be unique). | `number` | n/a | yes |
2 changes: 1 addition & 1 deletion instance.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ resource "proxmox_vm_qemu" "proxmox_instance" {

os_type = var.pxe_boot == true ? null : var.os_type
cicustom = var.pxe_boot == true ? null : var.cicustom
# example: "user=${var.citemplate_storage}:${var.snippet_dir}/user-${var.snippet_file_base},network=${var.citemplate_storage}:${var.snippet_dir}/network-${var.snippet_file_base}"
# example: "user=${local.citemplate_storage}:${local.snippet_dir}/user-${local.snippet_file_base},network=${local.citemplate_storage}:${local.snippet_dir}/network-${local.snippet_file_base}"
cloudinit_cdrom_storage = var.pxe_boot == true ? null : var.cloudinit_cdrom_storage
}
18 changes: 0 additions & 18 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -117,30 +117,12 @@ variable "os_type" {
type = string
}

variable "snippet_dir" {
default = "snippets"
description = "Name of the snippet subdirectory."
type = string
}

variable "snippet_file_base" {
default = "/var/lib/vz"
description = "Path to the directory containing the snippet_dir."
type = string
}

variable "cicustom" {
default = null
description = "Path(s) to cloud-init config files (ignored when pxe_boot is true)."
type = string
}

variable "citemplate_storage" {
default = null
description = "Name of the storage containing the cloud-init snippets (ignored when pxe_boot is true)."
type = string
}

variable "cloudinit_cdrom_storage" {
default = null
description = "Name of the storage to create the cloud-init image in (e.g. local-lvm)."
Expand Down

0 comments on commit 0e2002e

Please sign in to comment.