fix: fixed navbar "All Tools" not navigating to tools page

Refactor Navbar component and add Link component for navigation
a0v0 · Apr 30, 2024 · 7144204 · 7144204
2 parents 977d74f + e3bc1ce
commit 7144204
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 26 deletions.
diff --git a/components/Navbar.tsx b/components/Navbar.tsx
@@ -89,15 +89,6 @@ export const Navbar: FC<NavbarProps> = ({routes, slug, tag}) => {
     return null;
   }
 
-  const handlePressNavbarItem = (name: string, url: string) => {
-    trackEvent("NavbarItem", {
-      name,
-      action: "press",
-      category: "navbar",
-      data: url,
-    });
-  };
-
   return (
     <NextUINavbar
       ref={ref}
@@ -127,14 +118,9 @@ export const Navbar: FC<NavbarProps> = ({routes, slug, tag}) => {
       </NavbarContent>
       <NavbarContent className="hidden sm:flex gap-4" justify="start">
         <NavbarItem>
-          <Button
-            className="p-0 bg-transparent data-[hover=true]:bg-transparent"
-            href="/tools"
-            radius="sm"
-            variant="light"
-          >
+          <Link isBlock color="foreground" href={"/tools"}>
             All Tools
-          </Button>
+          </Link>
         </NavbarItem>
         {manifest.routes.map((category, index) =>
           category.routes.length > 0 ? (
@@ -172,13 +158,7 @@ export const Navbar: FC<NavbarProps> = ({routes, slug, tag}) => {
       <NavbarContent className="flex w-full gap-2 sm:hidden" justify="end">
         <NavbarItem className="flex h-full items-center">
           <ThemeSwitch />
-          <Link
-            isExternal
-            aria-label="Github"
-            className="p-1"
-            href={siteConfig.links.github}
-            onPress={() => handlePressNavbarItem("Github", siteConfig.links.github)}
-          >
+          <Link isExternal aria-label="Github" className="p-1" href={siteConfig.links.github}>
             <GithubIcon className="text-default-600 dark:text-default-500" />
           </Link>
         </NavbarItem>

diff --git a/components/hero.tsx b/components/hero.tsx
@@ -1,13 +1,13 @@
 "use client";
-import {Button, Link} from "@nextui-org/react";
+import {Button} from "@nextui-org/react";
 import {ArrowRightIcon} from "@nextui-org/shared-icons";
+import Link from "next/link";
 import {Logo} from "./icons";
 import {subtitle, title} from "./primitives";
 
 function HeroX() {
   return (
     <section className="flex flex-col gap-4 overflow-hidden lg:overflow-visible w-full flex-nowrap justify-between items-center h-[calc(100vh_-_64px)] 2xl:h-[calc(84vh_-_64px)]">
-      <div></div>
       <div className="inline-block  text-center justify-center">
         <center>
           <Logo />
@@ -22,7 +22,7 @@ function HeroX() {
           })}
         >
           Fast, beautiful and modern tools for everyone.
-        </h2>{" "}
+        </h2>
         <Button
           as={Link}
           endContent={<ArrowRightIcon />}