Improve getFullDn() to retrieve RDN #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous instance of getFullDn() naively composed the RDN that is then used in the user bind attempt by prefixing and suffixing the attributes defined in config.php. It may be desirable to allow login with an arbitrary attribute (i.e. mail address), or, as it is the case for me, when the LDAP server does not store the username as the primary key for the entity, and therefore a typical login based on uid would fail. I believe this change should not impact existing installations as it would still compose the same DN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous instance of getFullDn() naively composed the RDN that is then used in the user bind attempt by prefixing and suffixing the attributes defined in config.php.
It may be desirable to allow login with an arbitrary attribute (i.e. mail address), or, as it is the case for me, when the LDAP server does not store the username as the primary key for the entity, and therefore a typical login based on uid would fail.
I believe this change should not impact existing installations as it would still compose the same DN. My testing on this has however been limited.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.