Better handle of TIP banning in swap mode

Zondax · Oct 14, 2024 · 5b74c2e · 5b74c2e
1 parent f425f8b
commit 5b74c2e
Showing 1 changed file with 27 additions and 6 deletions.
diff --git a/app/src/swap/handle_sign_transaction.c b/app/src/swap/handle_sign_transaction.c
@@ -83,8 +83,9 @@ parser_error_t check_swap_conditions(parser_tx_t *txObj) {
     }
     // Check transaction method arguments number. Balance transfer Should be 3 (for tx v26).
     // [dest(address type) |  dest(address) | value(amount)]
-    if (txObj->blob.totalMethodItems != SWAP_EXPECTED_ITEMS) {
-        zemu_log("Wrong swap tx method arguments count.\n");
+    // We will check that index 5 does not have the TIP
+    if (txObj->blob.totalMethodItems != SWAP_EXPECTED_ITEMS && txObj->blob.totalMethodItems != SWAP_EXPECTED_ITEMS + 1) {
+        ZEMU_LOGF(100, "Wrong swap tx method arguments count %d.\n", txObj->blob.totalMethodItems);
         return parser_swap_tx_wrong_method_args_num;
     }
     // Check network.
@@ -102,7 +103,7 @@ parser_error_t check_swap_conditions(parser_tx_t *txObj) {
                            .pageCount = &pageCount};
 
     CHECK_ERROR(parser_getItem(txObj, &uiFields));
-    if (strncmp(valid_network, tmpValue, strlen(valid_network)) != 0) {
+    if (strncmp(valid_network, tmpValue, strlen(valid_network) + 1) != 0) {
         ZEMU_LOGF(200, "Swap not enable on %s network.\n", tmpValue);
         return parser_swap_tx_wrong_method;
     }
@@ -115,13 +116,24 @@ parser_error_t check_swap_conditions(parser_tx_t *txObj) {
     const char *valid_tx_call = "transfer_allow_death";
 
     CHECK_ERROR(parser_getItem(txObj, &uiFields));
-    if (strncmp(valid_tx_pallet, tmpKey, strlen(valid_tx_pallet)) != 0 ||
-        strncmp(valid_tx_call, tmpValue, strlen(valid_tx_call)) != 0) {
+    if (strncmp(valid_tx_pallet, tmpKey, strlen(valid_tx_pallet) + 1) != 0 ||
+        strncmp(valid_tx_call, tmpValue, strlen(valid_tx_call) + 1) != 0) {
         ZEMU_LOGF(200, "Wrong swap tx method (%s %s, should be : %s %s).\n", tmpKey, tmpValue, valid_tx_pallet,
                   valid_tx_call);
         return parser_swap_tx_wrong_method;
     }
 
+    // Check destination id
+    uiFields.displayIdx = 2;
+    MEMZERO(tmpKey, sizeof(tmpKey));
+    MEMZERO(tmpValue, sizeof(tmpValue));
+    const char *valid_field = "dest";
+    CHECK_ERROR(parser_getItem(txObj, &uiFields));
+    if (strncmp(valid_field, tmpKey, strlen(valid_tx_pallet) + 1) != 0) {
+        ZEMU_LOGF(200, "Wrong field (%s, should be : %s).\n", tmpKey, valid_field);
+        return parser_swap_tx_wrong_method;
+    }
+
     // // Check destination address.
     uiFields.displayIdx = 3;
     MEMZERO(tmpKey, sizeof(tmpKey));
@@ -143,7 +155,7 @@ parser_error_t check_swap_conditions(parser_tx_t *txObj) {
     MEMZERO(tmpValue, sizeof(tmpValue));
     if (parser_getItem(txObj, &uiFields) != parser_ok) {
         ZEMU_LOGF(100, "Could not parse swap tx amount.\n");
-        return parser_swap_tx_wrong_dest_addr;
+        return parser_swap_tx_wrong_amount;
     }
     char tmpAmount[100] = {0};
     const zxerr_t zxerr =
@@ -156,6 +168,15 @@ parser_error_t check_swap_conditions(parser_tx_t *txObj) {
         return parser_swap_tx_wrong_amount;
     }
 
+    // No item nb 5
+    uiFields.displayIdx = 5;
+    MEMZERO(tmpKey, sizeof(tmpKey));
+    MEMZERO(tmpValue, sizeof(tmpValue));
+    if (parser_getItem(txObj, &uiFields) == parser_ok) {
+        ZEMU_LOGF(100, "Refusing item number 5 %s.\n", tmpKey);
+        return parser_swap_tx_wrong_method_args_num;
+    }
+
     ZEMU_LOGF(50, "Swap parameters verified by current tx\n");
     return parser_ok;
 }