Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BG minions stats more Hearthstone-like #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piedpiper358
Copy link
Contributor

Before:

2022-08-13_20-50-51

After:

2022-08-13_21-03-52

Before:

2022-08-13_20-52-34

After:

2022-08-13_21-12-41

Decrease stats font size and add a stroke
@sebastientromp
Copy link
Contributor

I'm not really sure I like that change to be honest.
I don't feel like it makes the stats look that much closer to what HS has in-game (to do that would probably require another font altogether) and I don't like the visual style more than what is already in place today.

@piedpiper358
Copy link
Contributor Author

Yes, we should also use the font from Hearthstone (Belwe Bold). Can we use it?

@sebastientromp
Copy link
Contributor

No, it proprietary. And IMO not worth the cost :)

@piedpiper358
Copy link
Contributor Author

Maybe then we should find a free font that is more similar to Belwe? Passion One seems pretty far away.

@sebastientromp
Copy link
Contributor

Maybe then we should find a free font that is more similar to Belwe? Passion One seems pretty far away.

Yes, I'm open to using another font for the minion stats

@piedpiper358
Copy link
Contributor Author

Sumana looks much better. But the thing is, I can't test this properly because the stats style is in the coliseum repository.

Before:

2022-08-26_22-40-46

After:

2022-08-26_22-04-51

@sebastientromp
Copy link
Contributor

As it is I think it's less legible than the Passion One font. Maybe if we make the font bolder?

@piedpiper358
Copy link
Contributor Author

Yeah, bolder and with
-webkit-text-stroke-color: black;
-webkit-text-stroke-width: thick;

@sebastientromp
Copy link
Contributor

Is this what you have done already? If not, could you post an updated screenshot?

@piedpiper358
Copy link
Contributor Author

piedpiper358 commented Aug 29, 2022

This is:
font-family: 'Sumana'
font-size: 20px;
font-weight: 900;

2022-08-29_16-09-04

I think it's pretty close to Hearthstone

images

The point is that for some reason I can't override the font-family - rule in coliseum is too strong (!important doesn't help). And so I can't test it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants