add fix for invalid warband stats

Zero-to-Heroes · Mar 25, 2022 · ba94af2 · ba94af2
1 parent 9c36295
commit ba94af2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 234 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
 		"elementtree": "^0.1.7",
 		"immutable": "3.8.2",
 		"jszip": "^3.7.1",
-		"lodash-es": "4.17.15",
+		"lodash-es": "^4.17.21",
 		"mysql": "^2.17.1",
 		"node-fetch": "^2.6.7",
 		"sax": "1.2.4",

diff --git a/src/build-battlegrounds-hero-stats-new.ts b/src/build-battlegrounds-hero-stats-new.ts
@@ -182,7 +182,10 @@ const buildWarbandStats = (
 	rows: readonly InternalBgsRow[],
 ): readonly { turn: number; dataPoints: number; totalStats: number }[] => {
 	const data: { [turn: string]: { dataPoints: number; totalStats: number } } = {};
-	for (const row of rows) {
+	// Before that, there was an issue with disconnects, where the first turn after the
+	// reconnect would be turn 0, leading to an inflation of early turn stats
+	const validRows = rows.filter(row => row.id > 5348374);
+	for (const row of validRows) {
 		if (!row.warbandStats?.length) {
 			continue;
 		}

diff --git a/src/retrieve-bgs-global-stats.ts b/src/retrieve-bgs-global-stats.ts