Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies by switching to simplified API with a callback interface #157

Merged
merged 16 commits into from
Jun 4, 2024

Conversation

conradoplg
Copy link
Contributor

@conradoplg conradoplg commented May 23, 2024

zcash_script links in zcashd source code, and since the API takes a CTransaction that requires include a bunch of other stuff like orchard, etc.

This simplifies the API, by not passing the entire transaction but only the data required to verify. This makes this crate have ZERO Rust dependencies 🎉

This requires using a callback to compute the sighash, since to compute it you need some information that is extracted with zcash_script.cpp.

This approach does not decrease performance because it still allows the use of precomputation in the sighash: simply precompute and store in the ctx pointer, which will be forwarded to the sighash callback and can be used in the sighash computation by the caller.

@conradoplg conradoplg force-pushed the simplify-api branch 2 times, most recently from a15dd7d to 8e226cc Compare May 27, 2024 23:19
Cargo.toml Show resolved Hide resolved
@conradoplg conradoplg changed the title WIP: Simplify API Simplify API with callback interface May 29, 2024
@conradoplg conradoplg marked this pull request as ready for review May 29, 2024 22:51
@conradoplg conradoplg changed the title Simplify API with callback interface Remove all dependencies with simplified API with callback interface May 29, 2024
@conradoplg conradoplg changed the title Remove all dependencies with simplified API with callback interface Remove all dependencies with simplified API using callback interface May 29, 2024
@conradoplg conradoplg changed the title Remove all dependencies with simplified API using callback interface Remove most dependencies with simplified API using callback interface May 29, 2024
@conradoplg conradoplg changed the title Remove most dependencies with simplified API using callback interface Remove dependencies by switching to simplified API with a callback interface May 29, 2024
@arya2 arya2 self-requested a review June 3, 2024 17:07
@mpguerra mpguerra requested a review from upbqdn June 3, 2024 19:42
@upbqdn upbqdn merged commit 4924030 into master Jun 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants