Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.14 release #102

Merged
merged 8 commits into from
Oct 17, 2023
Merged

v0.1.14 release #102

merged 8 commits into from
Oct 17, 2023

Conversation

oxarbitrage
Copy link
Contributor

The versions bump are not here yet but just the upgrade from zcashd 5.6.0 to 5.7.0.

Unfortunatly there are a few small changes i had to do to the build.rs file for this to work. Any alternatives are welcome.

build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
@oxarbitrage
Copy link
Contributor Author

It seems the CI will not allow me to do the copying i did, i will have to find another way ...

https://github.com/ZcashFoundation/zcash_script/actions/runs/6489272390/job/17623221773?pr=102

Unsure about the clippy one as it is in the zcash code but that is a minor: https://github.com/ZcashFoundation/zcash_script/actions/runs/6489272390/job/17623221652?pr=102

@teor2345
Copy link
Contributor

Unsure about the clippy one as it is in the zcash code but that is a minor: ZcashFoundation/zcash_script/actions/runs/6489272390/job/17623221652?pr=102

I would suggest disabling this particular clippy warning in CI using -A clippy::(warning name).

@oxarbitrage
Copy link
Contributor Author

I would suggest disabling this particular clippy warning in CI using -A clippy::(warning name).

Yes that was already done at #103

Copy link
Contributor Author

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, can you approve ?

@conradoplg conradoplg merged commit 3fdf588 into master Oct 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants