Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages RFC #85

Merged
merged 70 commits into from
Jun 15, 2021
Merged
Changes from 69 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
5a86e0c
add a messages rfc
oxarbitrage May 2, 2021
c8eda81
update MsgDealerBroadcast
oxarbitrage May 4, 2021
d0a569c
remove msg type numbers, fix version msg
oxarbitrage May 4, 2021
0e4a911
update MsgCommitments
oxarbitrage May 4, 2021
994a67a
update MsgSigningPackage and MsgSignatureShare
oxarbitrage May 4, 2021
e4ecef9
remove non needed fields from MsgDealerBroadcast
oxarbitrage May 4, 2021
4cf6b87
update validate section
oxarbitrage May 4, 2021
4b88806
include the receiver side in validation section
oxarbitrage May 4, 2021
3d54c96
start a Serialized Size section
oxarbitrage May 4, 2021
f74f57c
complete the rest of the messages sizes
oxarbitrage May 4, 2021
b725e22
join serialization sections, readd `group_public` to initial msg
oxarbitrage May 5, 2021
b80a5a6
add frost:: to frost types, update intro, others
oxarbitrage May 5, 2021
dd0b7de
change better name for alias
oxarbitrage May 6, 2021
d0c8f18
unpack SigningPackage in MsgSigningPackage
oxarbitrage May 6, 2021
b3902e5
unpack commitments in MsgDealerBroadcast
oxarbitrage May 6, 2021
647d199
use affinepoint everywhere
oxarbitrage May 6, 2021
7394400
unpack VerificationKey
oxarbitrage May 6, 2021
c587e84
unpack Signature in MsgFinalSignature
oxarbitrage May 6, 2021
f98c5ce
update validation section
oxarbitrage May 6, 2021
1ee8059
byte order note
oxarbitrage May 6, 2021
61740e2
add size fields in MsgSigningPackage
oxarbitrage May 6, 2021
b608732
fix closing vector
oxarbitrage May 6, 2021
dc90235
replace tuples with new types
oxarbitrage May 8, 2021
104d0f5
add Other considerations section
oxarbitrage May 9, 2021
debcbc1
change other considerations section to not included
oxarbitrage May 9, 2021
0ea8af9
fix typos
oxarbitrage May 10, 2021
42763c1
use to_bytes in primitive types and reduce serialization size
oxarbitrage May 10, 2021
81ceee0
add note about large messages
oxarbitrage May 10, 2021
987cddd
change comments to doc comments
oxarbitrage May 10, 2021
b82e414
remove lenght of msg to be signed from rust
oxarbitrage May 10, 2021
28aefe2
replace CollectedCommitment with a HashMap
oxarbitrage May 10, 2021
c90f1e3
remove participants field from rust in MsgSigningPackage
oxarbitrage May 10, 2021
2293e1a
fix typo
oxarbitrage May 10, 2021
e14631b
change Participant to ParticipantID
oxarbitrage May 10, 2021
4284ddb
update payloads rust code
oxarbitrage May 11, 2021
300e503
add a new not included item
oxarbitrage May 11, 2021
b8abdf5
add line to AffinePoint description
oxarbitrage May 11, 2021
cf84c6f
update serialization
oxarbitrage May 11, 2021
0d51a74
add a new validation rules section
oxarbitrage May 11, 2021
632ed96
split rules in header and payload sub sections
oxarbitrage May 11, 2021
43a302b
fix missing field name and type in MsgCommitments serialization
oxarbitrage May 11, 2021
2d6290e
use some escape characters
oxarbitrage May 11, 2021
899ea9e
add definitions
oxarbitrage May 11, 2021
70eb9aa
Fix a typo
teor2345 May 12, 2021
a3d01a5
Name, Doc and Serialization Tweaks, and a Test Plan
teor2345 May 13, 2021
a53b40c
Remove the separate MsgCommitments type
teor2345 May 13, 2021
8955be9
Fix a missed type
teor2345 May 13, 2021
284d465
Add a constant for this serialization version
teor2345 May 13, 2021
86f5773
Reserve specific participant IDs for the dealer and aggregator
teor2345 May 13, 2021
79eda4e
Clarify participant ID changes
teor2345 May 13, 2021
9db4453
fix missing msg names
oxarbitrage May 13, 2021
ed337b6
split doc comment in lines
oxarbitrage May 13, 2021
5f3184e
remove some spaces after newlines
oxarbitrage May 13, 2021
e892d30
fix definitions after changes to ParticipantID
oxarbitrage May 13, 2021
111eab2
replace ParticipantID with ParticipantId everywhere remaining
oxarbitrage May 13, 2021
a1b9266
Make state-based validation out of scope
teor2345 May 13, 2021
c92b892
remove `msg_type` validation rule
oxarbitrage May 14, 2021
21c309f
change some validation rules
oxarbitrage May 14, 2021
29904a4
forbid multi-bytes in serialization
oxarbitrage May 17, 2021
1f5f04f
change group_public
oxarbitrage May 17, 2021
3c8494d
put variable-length fields last in messages
oxarbitrage May 19, 2021
74df415
text updates
oxarbitrage May 20, 2021
9b057f2
change ParticipantId to u64
oxarbitrage May 21, 2021
83794c5
change some primitives to frost types
oxarbitrage May 21, 2021
f9e73af
update a field description
oxarbitrage May 21, 2021
189efc2
use FrostSignature instead of Scalar primitive
oxarbitrage May 22, 2021
fa886e3
change type to `SignatureResponse`
oxarbitrage May 26, 2021
c4cb055
use BTreeMap, update sizes, etc
oxarbitrage May 31, 2021
de1f625
Convert `share_commitment` to a BTreeMap
oxarbitrage May 31, 2021
fa74969
add missing checks
oxarbitrage Jun 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading