fix: typos in documentation files #774
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All |
|
@conradoplg I checked for typos and corrected them where it was possible. |
mpguerra
reviewed
Nov 13, 2024
frost-p256/dkg.md
Outdated
| @@ -140,7 +140,7 @@ let mut key_packages = BTreeMap::new(); | |||
|
|
|||
| // Keep track of each participant's public key package. | |||
| // In practice, if there is a Coordinator, only they need to store the set. | |||
| // If there is not, then all candidates must store their own sets. | |||
| // If there is no, then all candidates must store their own sets. | |||
There was a problem hiding this comment.
I think this was fine the way it was
There was a problem hiding this comment.
@mpguerra Hi! Replacing 'not' with 'no' would be correct if the meaning of the phrase is that something is absent, rather than a negation, but I will do it as you say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains changes to improve clarity, correctness and structure.
Description correction:
Corrected "needs an unique" to "needs a unique".
Corrected "If there is not" to "If there is no".
Please review the changes and let me know if any additional changes are needed.