Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for redpallas #64

Merged
merged 4 commits into from
Sep 6, 2023
Merged

add support for redpallas #64

merged 4 commits into from
Sep 6, 2023

Conversation

conradoplg
Copy link
Contributor

Depends on #62

This adds support for RedPallas using the redpallas feature (e.g. cargo run --bin dkg --features redpallas)

Features should be additive and this goes against that, but since we have only binaries and not libraries, it seems fine.

When redpallas is activate, support for rerandomized FROST is also enabled. Currently the randomizer is always read (even though ideally it should be generated by the coordinator) because this is currently required by the demo.

Base automatically changed from use-serde to main August 7, 2023 13:55

input.read_line(&mut json).unwrap();

// TODO: fix error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be fixed as part of this story?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! forgot about it, fixed in 1e17731

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Just one question.

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@natalieesk natalieesk merged commit 32fb05b into main Sep 6, 2023
6 checks passed
@natalieesk natalieesk deleted the add-redpallas branch September 6, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants