This repository has been archived by the owner on Apr 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request in the Wiki.
Description
In this PR, I placed the
<header/>
tag before the<main>
tag. Even though the task suggested toRemove landmark tags (like header, footer, aside) from the <main>
, I decided to keep it simple and remove one of them as the other parts seem to follow the layout that was created.Fixes Issue
Closes #49
Acceptance Criteria
<Header />
components appears before the<main>
tag<Content />
and<Hero />
components stay inside the since they are containing the information of the main contentType of Changes
Make sure your code follows the code style of this project.
Make sure your code is up2date.
The title of the PR is the same as the title of the issue.
Updates
Before
After
Testing Steps / QA Criteria