Skip to content

Commit

Permalink
CI: Avoid keychain locking up
Browse files Browse the repository at this point in the history
The default timeout is 5 minutes, and notarization
takes way more than that, resulting in a locked
keychain.
  • Loading branch information
YuriSizov committed Jun 5, 2024
1 parent 225b653 commit 62e6376
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion .github/actions/sign-extension/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,4 @@ runs:
APPLE_DEV_TEAM_ID: ${{ inputs.apple-dev-team-id }}
APPLE_DEV_PASSWORD: ${{ inputs.apple-dev-password }}
FRAMEWORK_PATH: ${{ inputs.directory }}/${{ inputs.target-name }}
ARCHIVE_PATH: ${{ inputs.directory }}/framework.zip
run: $GITHUB_ACTION_PATH/macos/sign.sh
1 change: 1 addition & 0 deletions .github/actions/sign-extension/macos/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,4 @@ security find-identity
echo "Granting access to the keychain..."

security set-key-partition-list -S "apple-tool:,apple:" -s -k ${keychain_password} ${keychain}
security set-keychain-settings ${keychain}
8 changes: 2 additions & 6 deletions .github/actions/sign-extension/macos/sign.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ apple_dev_team_id="$APPLE_DEV_TEAM_ID"
apple_dev_password="$APPLE_DEV_PASSWORD"

framework_path="$FRAMEWORK_PATH"
archive_path="$ARCHIVE_PATH"
archive_path="$ARCHIVE_PATH.zip"

if [ -z "${apple_dev_id}" ]; then
echo "ERROR: Missing Apple developer ID."
Expand All @@ -30,16 +30,12 @@ if [ -z "${framework_path}" ]; then
echo "ERROR: Missing framework path to sign."
exit 1
fi
if [ -z "${archive_path}" ]; then
echo "ERROR: Missing target archive path."
exit 1
fi

# Sign and notarize the framework.

echo "Signing and verifying the framework at '${framework_path}'..."

codesign --verify --timestamp --verbose --deep --sign "${apple_dev_app_id}" "${framework_path}"
codesign --timestamp --verbose --deep --sign "${apple_dev_app_id}" "${framework_path}"
codesign --verify "${framework_path}"

echo "Archiving and notarizing the signed framework..."
Expand Down

0 comments on commit 62e6376

Please sign in to comment.