Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
windows: set CMAKE_MSVC_RUNTIME_LIBRARY for zlib
Since v1.3, zlib advertises compatibility with CMake 3.15 which added the MSVC_RUNTIME_LIBRARY [1] property, defaulting to the dynamically-linked runtime library. This seems to overrides our selection of MSVC runtime library passed through CMAKE_C_FLAGS_<CONFIG>. Ultimately, this results in a linker error when trying to link libfido2 and zlib. The generator expression used is the same as the default generator expression in CMake, with the exception of using the statically linked runtime library for static builds of libfido2. [1] https://cmake.org/cmake/help/latest/prop_tgt/MSVC_RUNTIME_LIBRARY.html
- Loading branch information