Skip to content

Commit

Permalink
winhello: add note about hmac-secret quirks
Browse files Browse the repository at this point in the history
  • Loading branch information
LDVG authored and kongeo committed Nov 6, 2023
1 parent 3d2e0d6 commit 7dc32f1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/winhello.c
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,10 @@ pack_cred_ext(WEBAUTHN_EXTENSIONS *out, const fido_cred_ext_t *in)
}
out->cExtensions = (DWORD)n;
if (in->mask & FIDO_EXT_HMAC_SECRET) {
/*
* NOTE: webauthn.dll ignores requests to enable hmac-secret
* unless a discoverable credential is also requested.
*/
if ((b = calloc(1, sizeof(*b))) == NULL) {
fido_log_debug("%s: calloc", __func__);
return -1;
Expand Down

0 comments on commit 7dc32f1

Please sign in to comment.