Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tests workflow #11

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fixing tests workflow #11

merged 2 commits into from
Dec 21, 2023

Conversation

Natooz
Copy link
Contributor

@Natooz Natooz commented Dec 21, 2023

In progress, this PR fixes the test CI workflow introduced in #6.
Notably, the base package directory is renamed back to symusic to fix the package local install. Testing locally should be performed by installing in editable mode: pip install -e ".[test]"

@Natooz
Copy link
Contributor Author

Natooz commented Dec 21, 2023

There is still this ModuleNotFoundError: No module named 'pybind11_tests' problem, which I don't know the cause but will try to solve here.

@Natooz Natooz marked this pull request as ready for review December 21, 2023 17:45
@Natooz
Copy link
Contributor Author

Natooz commented Dec 21, 2023

Pytest was simply grabbing the tests of the submodule, this is now fixed.
The tests are running, now we just have to fix the two remaining issues to make them pass! 🎉

@Yikai-Liao Yikai-Liao merged commit 7f47aba into Yikai-Liao:main Dec 21, 2023
1 of 4 checks passed
@Natooz Natooz deleted the tests-ci-fix branch December 22, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants