-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Apple Silicon #33
base: main
Are you sure you want to change the base?
Conversation
Edit: sorry, I'm taking it back. Although it compiles successfully without Rosetta, the app crashes when trying to render Google Maps. |
@oronbz I've set Metal renderer to fix this issue: GMSServices.setMetalRendererEnabled(true) |
Thanks @rbsgn I really hope this will get merge and this repository will keep being maintained, if it won't happen I don't mind collaborating with you on your fork or mine to keep this alive. |
Hey @rbsgn, any chance that this could be rebased on top of the new 7.1.0 version here? |
Hi @oronbz! What do you mean by “this”? This repository? I don’t own it and can’t rebase it, sorry. There is another fork that already uses 7.1.0. |
@rbsgn I mean rebase your branch on top of the main branch here, I know you don't own it (👍 Just trying the other fork now, thank you! |
In order for this project to generate xcframeworks that work with the same level of perfection on all devices including Apple Silicon simulators, we needed prebuilt Google binaries that are intended for those simulators. This is why I switched to using binaries that are hidden inside Google's beta-version xcframeworks.
Carthage now downloads the beta xcframeworks from Google, instead of the older frameworks. This is so that all the universal binaries hidden inside are made available.
References inside GoogleMaps.xcodeproj have been redirected to their respective counterparts in the xcframeworks – those intended for real devices.
A new project, GoogleMaps-Sim.xcodeproj, has been created, which works the same way, but is pointed at the files inside the xcframeworks that are intended for universal simulator devices (Intel and ARM).
The make_xcframework.sh script has been updated so that the new GoogleMaps-Sim.xcodeproj project is used when generating the framework which is intended for simulators.