Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve "Replace liballoc with Custom Heap" #368

Open
wants to merge 50 commits into
base: dev
Choose a base branch
from
Open

Resolve "Replace liballoc with Custom Heap" #368

wants to merge 50 commits into from

Conversation

Kfeavel
Copy link
Member

@Kfeavel Kfeavel commented Jan 25, 2022

Closes #367

@Kfeavel Kfeavel added enhancement An improvement on a pre-existing code high-priority Other issues depend upon this one labels Jan 25, 2022
@Kfeavel Kfeavel self-assigned this Jan 25, 2022
micahswitzer
micahswitzer reviewed Jan 25, 2022
View reviewed changes
Kernel/Library/string.cpp Outdated Show resolved Hide resolved
Kernel/Memory/Heap.cpp Outdated Show resolved Hide resolved
Kernel/Memory/Heap.cpp Show resolved Hide resolved
Kernel/Memory/Heap.cpp Outdated Show resolved Hide resolved
@Kfeavel Kfeavel force-pushed the 367-kernel-heap branch 2 times, most recently from 2c051ef to 909c2f8 Compare January 28, 2022 02:19
@Kfeavel Kfeavel force-pushed the 367-kernel-heap branch 2 times, most recently from c937c9c to 294476c Compare February 15, 2022 00:17
@Kfeavel Kfeavel marked this pull request as ready for review February 16, 2022 01:22
@Kfeavel
Copy link
Member Author

Kfeavel commented Feb 16, 2022

Will write some unit tests for this soon. Thanks to @micahswitzer for writing a basic one used for testing (janky-heap-tests).

@Kfeavel @micahswitzer
Rename heap to Liballoc
10c821f 
Moved so that the new heap code can live in Heap.cpp/.hpp
@Kfeavel @micahswitzer
Refactor LinkedList to not require template
9b2d64a 
Classes should instead publically inherit the `LinkedListNode` class
@Kfeavel @micahswitzer
Renamed LinkedListNode to Node
69c2401
@Kfeavel @micahswitzer
Begin writing new heap code
c54f1cf
@Kfeavel @micahswitzer
Partially complete malloc case 2
acac7af
@Kfeavel @micahswitzer
Make pageCount constant
4a41cfb
@Kfeavel @micahswitzer
Fix potential deadlock when out of memory
7cb50b5
@Kfeavel @micahswitzer
Complete malloc through part 4.1
56a05d8 
Likely will need fixing in some areas
@Kfeavel @micahswitzer
Complete malloc implementation
5080071 
Still need to fix pointer alignment issue
@Kfeavel @micahswitzer
Fix heap align compiler warning
8b810ab 
Needed to pass pointer of pointer for alignment to work properly
@Kfeavel @micahswitzer
Use getters and setters for heap Minor
c2c24e4 
Add getters for heap information (bytes allocated & bytes in use)
@Kfeavel @micahswitzer
Use RAII lock in malloc
0bc8bc4
@Kfeavel @micahswitzer
Fix incorrect LinkedList logic and parameter order
74fed55
@Kfeavel @micahswitzer
Fix head class naming & use linkedlist in Major
f566276
@Kfeavel @micahswitzer
Initialize heap and panic on stress test failure
1c348cc
@Kfeavel @micahswitzer
Heap: Fix incorrect if condition in malloc
3984417
@Kfeavel @micahswitzer
Heap: added log output for debugging
2298378
@Kfeavel @micahswitzer
Heap: Use InsertBack in malloc case 4.1
419deda
@Kfeavel @micahswitzer
Heap: Add more debug logging
034cc6a
@Kfeavel @micahswitzer
Heap: Adding missing call to unalign in free
9870c08
@Kfeavel @micahswitzer
Heap: Fix heap magic value by using rand twice
c736a9d
@Kfeavel @micahswitzer
Lib: Change data types in memmove and memcpy
1b5ef71
@Kfeavel @micahswitzer
Replace debugf with Logger::Debug
37c88f7
@Kfeavel @micahswitzer
Check for duplicate pointers in memory stress test
e91945a
@Kfeavel @micahswitzer
Fix infinite loop in heap case 1
adc7273
@Kfeavel @micahswitzer
Change startedBet to boolean
9af6fd9
@Kfeavel @micahswitzer
Fix minor block not being updated in case 4.1
69c0864
@Kfeavel @micahswitzer
Fix backwards linked list insertion arguments
8988573
@Kfeavel @micahswitzer
Demote heap logging from Debug to Trace
e35ffd8
@Kfeavel @micahswitzer
Reset spinner app
54d57b8
@Kfeavel @micahswitzer
Remove inconsistent linked list docs
49650f6
@Kfeavel @micahswitzer
Add brief to New.hpp
745a455
@Kfeavel @micahswitzer
Restructure unit tests
62aae39
@Kfeavel @micahswitzer
Add heap unit test
26de029
@Kfeavel @micahswitzer
Exclude unit test code from analysis
37592a0 
Prevents VSCode from becoming confused about class definitions
@Kfeavel @micahswitzer
Reorganize stubbed unit test code
8e8dc6f
@Kfeavel @micahswitzer
Add __xyris__ and __kernel__ to VSCode defines
67b67da
@Kfeavel @micahswitzer
Cleanup heap unit test
2f6d359
@Kfeavel @micahswitzer
Change heap byte alignment from 16 to 4
1611929
@Kfeavel @micahswitzer
Copy unit test from liballoc
6520489 
Tests allocations and frees of randomized sizes and positions
@Kfeavel @micahswitzer
Create VSCode configuration for unit tests
f36bdea 
Prevents Intellisense from becoming confused regarding definitions
conflicting or being declared in different namespaces
@Kfeavel @micahswitzer
Use std:: on functions when possible
c375a8a 
Should help remove ambiguity about what function is being called
(xyris vs host)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahswitzer micahswitzer Awaiting requested review from micahswitzer

At least 1 approving review is required to merge this pull request.

Assignees

@Kfeavel Kfeavel

Labels
enhancement An improvement on a pre-existing code high-priority Other issues depend upon this one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace liballoc with Custom Heap
2 participants
@Kfeavel @micahswitzer