Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asm] Specialize tile SSA names according to the tile kind #2025

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[asm] Specialize tile SSA names according to the tile kind #2025

wants to merge 2 commits into from
+466 −459

Conversation

keryell
Copy link
Member

@keryell keryell commented Jan 24, 2025

Specialize the SSA value names of the tiles according to their real functions to make text assembly clearer, like:
%tile_1_3 = aie.tile(1, 3)
%shim_noc_tile_0_0 = aie.tile(0, 0)
%mem_tile_0_1 = aie.tile(0, 1)

@keryell
[asm] Specialize tile SSA names according to the tile kind
f421ba0 
Specialize the SSA value names of the tiles according to their real functions to
make text assembly clearer, like:
    %tile_1_3 = aie.tile(1, 3)
    %shim_noc_tile_0_0 = aie.tile(0, 0)
    %mem_tile_0_1 = aie.tile(0, 1)
@keryell keryell requested a review from erwei-xilinx January 24, 2025 23:33
@keryell
Copy link
Member Author

keryell commented Jan 24, 2025

This is the followup of Erwei's presentation today showing thousands of lines of MLIR-AIE generated from MLIR-AIR. 😄

@keryell keryell marked this pull request as ready for review January 25, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwei-xilinx erwei-xilinx erwei-xilinx approved these changes

@stephenneuendorffer stephenneuendorffer stephenneuendorffer approved these changes

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca is a code owner

@jgmelber jgmelber Awaiting requested review from jgmelber jgmelber is a code owner

@fifield fifield Awaiting requested review from fifield fifield is a code owner

@jackl-xilinx jackl-xilinx Awaiting requested review from jackl-xilinx jackl-xilinx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keryell @stephenneuendorffer @erwei-xilinx