Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrt-smi rearchitecture Patch 4 #8714

Merged
merged 17 commits into from
Jan 28, 2025
Merged

xrt-smi rearchitecture Patch 4 #8714

merged 17 commits into from
Jan 28, 2025

Conversation

aktondak
Copy link
Collaborator

@aktondak aktondak commented Jan 23, 2025

Problem solved by the commit

This PR does the following :

  1. Replaces embedded json configuration to a generated configuration. This generation code is common to all shims and each shim will derive from it to define whatever custom xrt-smi behavior they want to have.
  2. Adds support for allowing multi-configuration Description field for xrt-smi options (through description_array). With this, the test and report list are simple vector stores and formatting is taken care of by XRT correctly.
  3. Builds SubCmdJsonObjects only with xbutil and xbmgmt objects only as it should be.
  4. Also fixes CR-1226870. This issue was caused due to incorrect configuration in default device cases.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

Problem was discovered when we wanted to scale to multiple different tests separately in each shim.
https://jira.xilinx.com/browse/CR-1226870

How problem was solved, alternative solutions (if any) and why they were rejected

Solved through addition of a new field.

Risks (if any) associated the changes in the commit

xrt-smi should be tested for alveo devices.

What has been tested and how, request additional testing if necessary

Tested with MCDM and XDNA drivers.

Documentation impact (if any)

None

Signed-off-by: Akshay Tondak <[email protected]>
@gbuildx
Copy link
Collaborator

gbuildx commented Jan 23, 2025

Can one of the admins verify this patch?

@aktondak aktondak added the do not merge hold off on merging label Jan 23, 2025
@aktondak aktondak removed the do not merge hold off on merging label Jan 24, 2025
src/runtime_src/core/common/smi.cpp Outdated Show resolved Hide resolved
src/runtime_src/core/common/smi.cpp Outdated Show resolved Hide resolved
src/runtime_src/core/common/smi.h Outdated Show resolved Hide resolved
@aktondak aktondak requested a review from stsoe January 27, 2025 22:14
Signed-off-by: Akshay Tondak <[email protected]>
Copy link
Collaborator

@stsoe stsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style change requests, else looks good.

src/runtime_src/core/common/smi.cpp Outdated Show resolved Hide resolved
src/runtime_src/core/common/smi.cpp Outdated Show resolved Hide resolved
src/runtime_src/core/common/smi.cpp Outdated Show resolved Hide resolved
src/runtime_src/core/common/smi.cpp Outdated Show resolved Hide resolved
src/runtime_src/core/common/smi.h Outdated Show resolved Hide resolved
src/runtime_src/core/common/smi.h Outdated Show resolved Hide resolved
src/runtime_src/core/common/smi.h Outdated Show resolved Hide resolved
src/runtime_src/core/edge/user/device_linux.cpp Outdated Show resolved Hide resolved
src/runtime_src/core/edge/user/smi.cpp Outdated Show resolved Hide resolved
src/runtime_src/core/edge/user/smi.h Outdated Show resolved Hide resolved
@aktondak aktondak requested a review from stsoe January 28, 2025 18:52
Copy link
Collaborator

@stsoe stsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for making the changes.

@stsoe stsoe merged commit 275bbcb into Xilinx:master Jan 28, 2025
20 checks passed
@aktondak aktondak deleted the VITIS-13904 branch January 28, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants