Fix error when build base component #8707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amend Xilinx#8706. Use dummy value or XRT_DEV_COMPONENT when building only base component. Tempoary fix for cpackLin conditionally adding dependencies for legacy XRT when XRT_DEV_COMPONENT equals "xrt". We don't want the dependencies in case of base package so use dummy value to by-pass. Also, ensure that pcie/linux shim is built only when XRT_BASE is active. Linux shim is shared between npu and alveo, hence should be in base component only. Signed-off-by: Soren Soe <[email protected]>
rchane
pushed a commit
to rchane/XRT
that referenced
this pull request
Jan 24, 2025
Amend Xilinx#8706. Use dummy value or XRT_DEV_COMPONENT when building only base component. Tempoary fix for cpackLin conditionally adding dependencies for legacy XRT when XRT_DEV_COMPONENT equals "xrt". We don't want the dependencies in case of base package so use dummy value to by-pass. Also, ensure that pcie/linux shim is built only when XRT_BASE is active. Linux shim is shared between npu and alveo, hence should be in base component only. Signed-off-by: Soren Soe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Amend #8706. Use dummy value or XRT_DEV_COMPONENT when building only base component.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Tempoary fix for cpackLin conditionally adding dependencies for legacy XRT when XRT_DEV_COMPONENT equals "xrt". We don't want the dependencies in case of base package so use dummy value to by-pass.
Also, ensure that pcie/linux shim is built only when XRT_BASE is active. Linux shim is shared between npu and alveo, hence should be in base component only.