Modified the aie-rt function APIs and updated the datatype of its parameter from u8 to u16 #8692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManojTakasi
requested review from
jvillarre,
larry9523,
jeffli-xilinx,
rozumx,
sonals and
stsoe
as code owners
pgschuey
requested changes
Jan 14, 2025
There was a problem hiding this comment.
This looks like a much better set of changes as it avoids client-based code which already supports 16 bits. My only concern is this PR conflicts with PR 8689. Given that this is now the third set of changes which the other PR has had to merge/accommodate, I would suggest waiting for PR 8689 to merge, then make the appropriate adjustments to this PR and merge accordingly.
…ameter from u8 to u16 Signed-off-by: Manoj Takasi <[email protected]>
|
Hi, the required changes have already been made in the mentioned PR-8689. Therefore, I will be closing this PR. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR is the same as #8684. Reverted the changes on the client side.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
No functionality changes.
How problem was solved, alternative solutions (if any) and why they were rejected
By modifying the mentioned APIs and its parameter from u8 to u16.
Risks (if any) associated the changes in the commit
low
What has been tested and how, request additional testing if necessary
Ran graph test case by building and installing xrt,czocl, aiefal, libaiengine packages on vck190.
Documentation impact (if any)