Skip to content

Commit

Permalink
Added override to ensure the functions correctly overrides a base cla…
Browse files Browse the repository at this point in the history
…ss virtual function. (#8632)

Signed-off-by: Manoj Takasi <[email protected]>
Co-authored-by: Manoj Takasi <[email protected]>
  • Loading branch information
ManojTakasi and Manoj Takasi authored Dec 4, 2024
1 parent 1d2509d commit debb41c
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions src/runtime_src/core/edge/user/device_linux.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ class device_linux : public shim<device_edge>
// query functions
virtual void read_dma_stats(boost::property_tree::ptree& pt) const;

virtual void read(uint64_t addr, void* buf, uint64_t len) const;
virtual void write(uint64_t addr, const void* buf, uint64_t len) const;
virtual void read(uint64_t addr, void* buf, uint64_t len) const override;
virtual void write(uint64_t addr, const void* buf, uint64_t len) const override;
virtual void reset(const query::reset_type) const;

////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -70,29 +70,29 @@ class device_linux : public shim<device_edge>
// Custom ip interrupt handling
// Redefined from xrt_core::ishim
////////////////////////////////////////////////////////////////
virtual xclInterruptNotifyHandle
open_ip_interrupt_notify(unsigned int ip_index)
xclInterruptNotifyHandle
open_ip_interrupt_notify(unsigned int ip_index) override
{
return xclOpenIPInterruptNotify(get_device_handle(), ip_index, 0);
}

virtual void
close_ip_interrupt_notify(xclInterruptNotifyHandle handle)
void
close_ip_interrupt_notify(xclInterruptNotifyHandle handle) override
{
xclCloseIPInterruptNotify(get_device_handle(), handle);
}

virtual void
enable_ip_interrupt(xclInterruptNotifyHandle);
void
enable_ip_interrupt(xclInterruptNotifyHandle) override;

virtual void
disable_ip_interrupt(xclInterruptNotifyHandle);
void
disable_ip_interrupt(xclInterruptNotifyHandle) override;

virtual void
wait_ip_interrupt(xclInterruptNotifyHandle);
void
wait_ip_interrupt(xclInterruptNotifyHandle) override;

virtual std::cv_status
wait_ip_interrupt(xclInterruptNotifyHandle, int32_t timeout);
std::cv_status
wait_ip_interrupt(xclInterruptNotifyHandle, int32_t timeout) override;

virtual std::unique_ptr<hwctx_handle>
create_hw_context(const xrt::uuid& xclbin_uuid,
Expand Down

0 comments on commit debb41c

Please sign in to comment.