CR-1217444 Callback on xrt::run causes "kds monitor died" and hang (#…

…8562)

Trap unsupposed managed execution earlier.

We don't plan on supporting callbacks for xrt::run objects for
RyzenAI.  This would kill performance.  Callbacks are used under the
hood in the OpenCL implementation and are indeed supported for XRT
native APIs on Alveo, but not for RyzenAI

This PR changes code such that an exception is thrown when an xrt::run
object is started after adding a callback on the run object.

Signed-off-by: Soren Soe <[email protected]>

src/runtime_src/core/common/api/hw_queue.cpp

@@ -412,7 +412,7 @@ class hw_queue_impl : public command_manager::executor
 
   // Managed start uses command manager for monitoring command
   // completion
-  void
+  virtual void
   managed_start(xrt_core::command* cmd)
   {
     get_cmd_manager()->launch(cmd);
@@ -440,6 +440,16 @@ class qds_device : public hw_queue_impl
     , m_qhdl(qhdl)
   {}
 
+  // Managed start is invoked when application has added a callback
+  // function for notification of command completion. This is not
+  // supported for platforms that implement hwqueue_handle (see
+  // details in wait(size_t) comments.
+  void
+  managed_start(xrt_core::command*) override
+  {
+    throw std::runtime_error("Managed execution is not supported for this device");
+  }
+
   std::cv_status
   wait(size_t /*timeout_ms*/) override
   {