-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Databrowser timepicker #75
base: master
Are you sure you want to change the base?
Conversation
no functionality yet
Can we eliminate the |
|
delete treeview test files, that were accidentally commited
As discussed, this PR needs:
|
We did not discuss. |
There's a conflict between the selection of the time range from the radio buttons and the datetime box. Changing the datetime range to a custom value doesn't update the radio buttons. I think the UI can also be made more concise by changing the radiobuttons to QComboBox with options "All", "30 Days", "Today", "Last Hour", and "Custom...". Then we only need to show the datetime range UI when "Custom..." is selected.
|
Fix: Radio buttons are now reset, when custom datetime range is selected. |
I can't easily confirm, but I think I see a flaw. I suspect that newly generated runs won't be shown when the standard time span modes are used, since it gets time.time() when the mode is selected, not during each update. I'm going to attempt refactoring. |
Yes, it would be a flaw if new runs don't show up, due of the time span not being adapted. I can have a look into that. How would it be any different for using QComboBox dropdown instead of Radiobuttons, that should not make a difference? |
This work was revisited in bluesky/bluesky-widgets#13, now merged. Safe to close this PR? |
I added 4 QRadiobuttons to the search_input_widget to quickly select time ranges for the catalog search. I used QTDesigner for the actual layout. The .ui files were converted to .py and then I import the classes into gui/bluesky/search.py