Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfluxDB Health Check #704

Merged
merged 96 commits into from
Dec 24, 2022
Merged

InfluxDB Health Check #704

merged 96 commits into from
Dec 24, 2022

Conversation

maikebing
Copy link
Contributor

No description provided.

sungam3r
sungam3r reviewed Dec 29, 2020
View reviewed changes
build/dependencies.props Outdated Show resolved Hide resolved
sungam3r
sungam3r reviewed Dec 29, 2020
View reviewed changes
build/dependencies.props Outdated Show resolved Hide resolved
@maikebing
Copy link
Contributor Author

Hi, Do you have time to review this code? @sungam3r

@sungam3r sungam3r added this to the V7 Release milestone Dec 23, 2022
@sungam3r
Copy link
Collaborator

Setup InfluxDB step hangs.

@maikebing
Copy link
Contributor Author

Setup InfluxDB step hangs.

I'm trying to fix this.

@maikebing
Copy link
Contributor Author

maikebing commented Dec 24, 2022 •
edited
Loading

The test passed.
https://github.com/maikebing/AspNetCore.Diagnostics.HealthChecks/actions/runs/3770054697/jobs/6409645399

@maikebing
Copy link
Contributor Author

Since the script for influxdata/influxdb-action does not work with the new influxdb 2.6.0 package, the script has been fixed and the PR has been opened ， influxdata/influxdb-action#3

sungam3r
sungam3r reviewed Dec 24, 2022
View reviewed changes
.github/workflows/healthchecks_influxdb_ci.yml
dotnet build --no-restore ./src/HealthChecks.InfluxDB/HealthChecks.InfluxDB.csproj &&
dotnet build --no-restore ./test/HealthChecks.InfluxDB.Tests/HealthChecks.InfluxDB.Tests.csproj
- name: Setup InfluxDB
uses: maikebing/influxdb-action@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Then ping back when fix will be merged in official repo. I will review today and merge.

sungam3r
sungam3r reviewed Dec 24, 2022
View reviewed changes
docker-compose.yml
- "6222:6222"
influx:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file used on CI?

@sungam3r sungam3r merged commit d759df1 into Xabaril:master Dec 24, 2022
@sungam3r
Copy link
Collaborator

@maikebing Thanks. Almost 2-year journey.

@maikebing
Copy link
Contributor Author

Thanks for reviewing and merging!

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r sungam3r approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
V7 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@maikebing @sungam3r