stop iteration when module instance found

XKNX · Nov 2, 2023 · e6fb4b2 · e6fb4b2
1 parent 7442fe0
commit e6fb4b2
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/xknxproject/models/models.py b/xknxproject/models/models.py
@@ -206,13 +206,16 @@ def _add_com_object_instance_numbers(self) -> None:
                 or coir.number is None  # only for type safety
             ):
                 continue
-            for mi in self.module_instances:
-                if coir.ref_id.startswith(f"{mi.identifier}_"):
-                    coir.number += next(
-                        int(arg.value)
-                        for arg in mi.arguments
-                        if arg.ref_id == coir.base_number_argument_ref
-                    )
+            _module_instance = next(
+                mi
+                for mi in self.module_instances
+                if coir.ref_id.startswith(f"{mi.identifier}_")
+            )
+            coir.number += next(
+                int(arg.value)
+                for arg in _module_instance.arguments
+                if arg.ref_id == coir.base_number_argument_ref
+            )
 
     def apply_module_instance_arguments(self) -> None:
         """Apply module instance arguments."""