Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean deprecate_kwarg #1470

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Clean deprecate_kwarg #1470

merged 1 commit into from
Nov 15, 2024

Conversation

dachengx
Copy link
Collaborator

Close: #1469

These kwargs should be deprecated because no one should use them since straxen 3.0.0.

@dachengx dachengx marked this pull request as ready for review November 15, 2024 01:44
@yuema137 yuema137 self-requested a review November 15, 2024 02:10
@coveralls
Copy link

coveralls commented Nov 15, 2024 •
edited
Loading

Coverage Status

coverage: 90.216% (+0.02%) from 90.201%
when pulling d5b0ddd on clean_deprecate_kwarg
into 6a9a141 on master.

@dachengx dachengx merged commit 00d0a33 into master Nov 15, 2024
8 checks passed
@dachengx dachengx deleted the clean_deprecate_kwarg branch November 15, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuema137 yuema137 yuema137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean deprecate_kwarg
3 participants
@dachengx @coveralls @yuema137