Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collection after calculated each chunk in peak_positions_mlp #1467

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Garbage collection after calculated each chunk in peak_positions_mlp #1467

merged 1 commit into from
Nov 14, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Nov 14, 2024 •
edited
Loading

Depends on AxFoundation/strax#922.

Because peak_positions_mlp is memory-consuming:

image. Garbage collection after we make increments in the calculation might be helpful.

slack thread

@dachengx dachengx marked this pull request as ready for review November 14, 2024 07:47
@dachengx dachengx changed the title Garbage collection after calculated each MLP chunk Garbage collection after calculated each chunk in peak_positions_mlp Nov 14, 2024
@coveralls
Copy link

coveralls commented Nov 14, 2024 •
edited
Loading

Coverage Status

coverage: 90.22% (+0.02%) from 90.199%
when pulling 12117a1 on gc_collect_after_compute_mlp
into f1bb229 on master.

@dachengx dachengx merged commit 8fedc98 into master Nov 14, 2024
8 checks passed
@dachengx dachengx deleted the gc_collect_after_compute_mlp branch November 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @coveralls