-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YBe Generator #134
Add YBe Generator #134
Conversation
for more information, see https://pre-commit.ci
Maybe to combine ambe and ybe generator (also maybe neutron_gun in the future) to nr_generator? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @ghusheng. I would just keep the generator itself and remove other things. One thing we might need to think about is to put all the csv inputs (together with the AmBe's) into a more shared-like folder something like: /project/lgrandi/xenonnt/saltax_inputs
. Maybe in another PR.
Meanwhile, since AmBe and YBe are so different in energy and positions I would avoid putting them into one generator. It makes no sense to me to sprinkle ambe neutrons into a ybe runs.
.singularity_inner
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go
jobs/config.ini
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the template so not to touch this
jobs/config_ybe.ini
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the original config as a template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, but I am a bit lazy to test, so I would just trust you:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me do a minor change
Ignore the tests, they are nonsense for now. |
should be all good now |
Add
generator_ybe
in the generator.py , the default YBe instruction file path is/project2/lgrandi/ghusheng/ybe_instrutions/ybe_wfsim_instructions_6806_events_time_modified.csv