fix: Update chart relese workflow, relocate charts #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascheibal
changed the title
ascheibal
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue with the chart release action not being able to locate the chart.
REQUIREMENTS:
The workflow permissions need to be set to read and write permissions. Before merging this PR please go to Settings -> Actions -> General -> Workflow permissions and set it to
Read and write permissions. Unfortunately write permissions can not be granted implicitly from the workflow, and this is necessary so the release of the charts can be done from a workflow, and the insertion of the index.yaml that's required for the chart repo to function.If granting write access to all workflows is undesired, a GitHub app or a PAT with read, write, release permissions is needed insted, and the token has to be added as a secret and consumed in the workflow.