Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart 3 support #71

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

mateuszwojtczak
Copy link
Contributor

@mateuszwojtczak mateuszwojtczak commented Oct 25, 2023

Motivation

After our project got upgraded to Dart 3, our codemods can't resolve packages.

Changes

Dart version constraint got bumped to >3.0.0 <4.0.0.
Also this broke mockito dependency, so I replaced it with now-standard mocktail.

Release Notes

Added Dart 3 support

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

aviary-wf commented Oct 25, 2023

Security Insights

Error scanning for security relevant context

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@evanweible-wf
Copy link
Contributor

Thank you for the PR @mateuszwojtczak! I'm going to merge this into a WIP branch and see if I can get it supporting both Dart 2 and 3 and then I'll get this merged and released

@evanweible-wf evanweible-wf changed the base branch from master to dart3_wip October 31, 2023 17:40
@evanweible-wf evanweible-wf merged commit cc6dee2 into Workiva:dart3_wip Oct 31, 2023
4 checks passed
@evanweible-wf
Copy link
Contributor

Should be released as v1.1.0 now, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants