fix(mvp): Stage 1 - clean php includes #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhooks
force-pushed
the
fix/clean-includes
branch
2 times, most recently
from
6f8ac24 to
5b50a52
Compare
johnhooks
added
the
[Scope] Model
johnhooks
changed the title
johnhooks
force-pushed
the
fix/clean-includes
branch
from
0e81f62 to
33f6353
Compare
johnhooks
changed the title
johnhooks
changed the title
johnhooks
changed the title
johnhooks
added
php
Sephsekla
approved these changes
Apr 20, 2023
johnhooks
requested review from
Sephsekla and
erikyo
and removed request for
erikyo
Sephsekla
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove unused code.
Why?
In preparation for 0.3.0 and integrating the work done in #259, It would be a good time to clean up code that we do not expect to use. Before drawing more attention to the repo, we should make sure it reflects the current direction of the project.
How?