Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add seed channels command #214

Closed
wants to merge 2 commits into from
Closed

feature: add seed channels command #214

wants to merge 2 commits into from

Conversation

johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 2, 2023 •
edited
Loading

What?

WIP

Add a wp-cli command to seed the database with notification channel data.

Why?

To support testing and the plugin demo.

How?

Add wp-cli/wp-cli-bundle as a dev dependency and begin work implementing the cli interface.

Begins work on Issue Issue #200.

TODO

@johnhooks johnhooks marked this pull request as draft April 2, 2023 19:27
@johnhooks johnhooks added [Scope] Database / Persistence Issue related to storing data. To WP database or another location. php Pull requests that update Php code [Status] Blocked When another issue need to be taken care of first. labels Apr 2, 2023
@johnhooks johnhooks force-pushed the feature/add-seed-command branch from 4d685df to ffd414a Compare April 2, 2023 19:34
@johnhooks
Copy link
Collaborator Author

johnhooks commented Apr 2, 2023 •
edited
Loading

@JasonTheAdams I'm drawing pretty heavy on the GiveWP code base, how would you recommend attribution? Nothing has been whole sale copied, but I want to make sure I do this right. (also don't judge this too harshly... yet, its still a work in progress)

@johnhooks johnhooks force-pushed the feature/add-seed-command branch from ffd414a to 084076d Compare April 5, 2023 02:30
@JasonTheAdams
Copy link
Collaborator

@JasonTheAdams I'm drawing pretty heavy on the GiveWP code base, how would you recommend attribution? Nothing has been whole sale copied, but I want to make sure I do this right. (also don't judge this too harshly... yet, its still a work in progress)

Hahah! Thanks for the thought. It's really not a big deal. If you really want you can leave an attribution in some doc block, but don't worry. I'm just happy to share what we've got. 🙂

@johnhooks johnhooks force-pushed the feature/add-seed-command branch from 084076d to f6551a7 Compare April 12, 2023 16:35
@johnhooks johnhooks mentioned this pull request Apr 12, 2023
Closed
38 tasks
@johnhooks
Copy link
Collaborator Author

There are are commands to seed the database in #259, and also channels are not currently planned to be stored in the database.

@johnhooks johnhooks closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnhooks johnhooks

Labels
php Pull requests that update Php code [Scope] Database / Persistence Issue related to storing data. To WP database or another location. [Status] Blocked When another issue need to be taken care of first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnhooks @JasonTheAdams