Simplify the Two Factor settings in user profile #654
Conversation
# Conflicts: # class-two-factor-core.php
|
Curious to hear what others think about this proposal. @dd32 Do you have any concerns with this in regards to various integrations that insert themselves into this view? |
Required for settings and to seperate from default pick by system
|
Noting this change would close #342. I do like moving the Primary radio button out to a dropdown single select option, as that handles for most of the setup UX confusion for users. It might make sense to group the Email / Auth app / U2F / Codes / Dummy, etc. bits into a "Two-factor methods" section so that the Primary Method setting appears more clearly separate to the method configurations. Finally, a small tweak to the Primary Method helper copy from |
|
Great suggestions @jeffpaul, thanks!
We currently have everything under "Two-Factor Options". Something like this? Two-FactorConfigure a primary... Two-Factor MethodsMethod A - [ ] Enable Method A Two-Factor Primary MethodPrimary method dropdown. |
|
Yes, adding those headings I think helps separate things just a bit and mimics how other WP core settings pages group things. I admit I was thinking more visually to have horizontal lines/separators but I think following WP core and using H2/H3/etc is probably the better/right approach. |
Not at all! |
# Conflicts: # class-two-factor-core.php
|
@jeffpaul I've updated the copy for the default method per your suggestion. Also, I feel like your suggestion about a line separator works better than headings for each section which it makes it way nosy. I've updated the pull request description with the latest screenshot. Please let me know your thoughts. |
| * | ||
| * @return string|null | ||
| */ | ||
| private static function get_primary_provider_key_selected_for_user( $user ) { |
There was a problem hiding this comment.
This is a dedicated helper to get the selected option without attempting to resolve if the method is active or not.
Fixes #342.
With the recent changes to the admin UX in #623, we have the opportunity to simplify it even further and make it look more native to the core WP settings.
What?
Switch to a standard two column layout with section headings on the right:
on mobile:
Why?
How?
This proposal relies on the core idea that the primary method selector can be moved to a dedicated dropdown instead of using the radio buttons next to each method configuration.
Importantly:
The primary method selector is a pure convenience thing as the user can switch between all of the enabled methods during the login phase anyway. The plugin could show the most secure option, by default, if no primary is specified.
Secondly, the primary method doesn't need to be configured if the user has only one two factor method enabled (and the backup codes, for example). The plugin can be smart enough to guess the primary method.
Considerations:
Testing Instructions
Screenshots or screencast
Changelog Entry
Changed - simplify the two-factor options on the user profile page by moving the primary method selector to a dedicated dropdown field which is more aligned with the WordPress core UX.