Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove required property from fields #175

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove required property from fields #175

merged 1 commit into from
Dec 18, 2024

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Dec 18, 2024 •
edited
Loading

Fixes #162

@psrpinto psrpinto self-assigned this Dec 18, 2024
@psrpinto psrpinto requested a review from ashfame December 18, 2024 14:58
ashfame
ashfame approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@ashfame ashfame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@psrpinto psrpinto merged commit 3f3f89d into trunk Dec 18, 2024
3 checks passed
@psrpinto psrpinto deleted the schema-remove-required branch December 18, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfame ashfame ashfame approved these changes

Assignees

@psrpinto psrpinto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema: required attribute might be unnecessary
2 participants
@psrpinto @ashfame